fix: enable controller update in case of multiple belongsTo relation - #9461
Open
aaqilniz wants to merge 1 commit into
Open
fix: enable controller update in case of multiple belongsTo relation#9461aaqilniz wants to merge 1 commit into
aaqilniz wants to merge 1 commit into
Conversation
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
April 21, 2023 06:46
67ce8fd to
de6330d
Compare
Pull Request Test Coverage Report for Build 4905329974Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
aaqilniz
marked this pull request as ready for review
April 21, 2023 10:48
samarpanB
requested changes
Apr 23, 2023
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
April 23, 2023 13:41
de6330d to
d198007
Compare
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
May 7, 2023 04:31
d198007 to
2297f06
Compare
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
2 times, most recently
from
June 17, 2023 08:09
2297f06 to
7bb46ef
Compare
aaqilniz
marked this pull request as draft
June 18, 2023 04:58
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
June 18, 2023 05:38
9c11d55 to
14e1f54
Compare
aaqilniz
marked this pull request as ready for review
June 18, 2023 06:19
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
October 7, 2023 17:29
14e1f54 to
219624c
Compare
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
February 7, 2024 07:05
e49e5b5 to
835c000
Compare
Contributor
Author
|
Hi, @samarpanB. Can you have a look at this PR of mine? |
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
March 26, 2025 16:47
835c000 to
3abecb8
Compare
Contributor
Author
|
Hi, @dhmlau. Can you please have a look at this PR? |
Contributor
Author
|
Hi, @samarpanB. I have added a Dockerfile to show the problem. Please have a look at this whenever you get the chance. |
Signed-off-by: Muhammad Aaqil <aaqilniz@yahoo.com>
aaqilniz
force-pushed
the
fix/multi-belongsTo
branch
from
May 1, 2026 03:41
6914cbb to
97c3f32
Compare
Contributor
Author
|
Hi, @dhmlau. Can you have a look at this PR whenever you get the chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to create more than one belongsTo relation, cli asks to replace the controller file (as it creates the new file and considers a conflict).
The model and repository files are updated just fine. The only issue that happens is with the controller file.
I am sharing a Dockerfile that can be used to reproduce this issue.
After starting the container, it can be noticed that the model and repo files are updated but the controller file has no changes.
This PR adds a check if the controller file already exists and then updates it. And if it doesn't exist, it creates the file.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈